Repository navigation
Omit the id of an error response when it is unknown - #607
Closed
dominikklein wants to merge 1 commit into
Closed
dominikklein wants to merge 1 commit into
dominikklein wants to merge 1 commit into
Conversation
MCP's error responses have an optional string or integer id, so an id the server couldn't read is now left out instead of being sent as null. Fixes modelcontextprotocol#606.
Member
|
Closing in favor of #615, which leaves the Thank you for the report and the schema references in #606. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP's error responses have an optional string or integer id, so an id the server couldn't read is now left out instead of being sent as
null. This coversJsonRpcHandler.error_responseand the transport'sjson_rpc_error_responseandinvalid_request_response. A wrong content type now returns:{"jsonrpc":"2.0","error":{"code":-32600,"message":"Unsupported Media Type: Content-Type must be application/json"}}The tests that checked for a
nilid now check that the member is absent, including the listen test that assertednullon purpose.Fixes #606.